Turn rich content on by default, fetching external content on demand#4069
Merged
Conversation
Evaluating a File or URL-shaped result no longer auto-fires a slurp request (the behavior that got the feature disabled back in 0.25, see #2825). The REPL now renders the URL plus a [show content] button and nothing is transferred until it's pressed. Inline image results are unaffected - they involve no IO and still render automatically. With the danger gone, cider-repl-use-content-types defaults to t, so images finally render in the REPL out of the box. Best paired with cider-nrepl 0.62+, which hardens the server side (scheme allowlist, size caps, graceful fetch errors).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The client half of the rich-content revival (pairs with clojure-emacs/cider-nrepl#1025, see #2825 for the history).
Evaluating a
Fileor URL-shaped result no longer auto-fires a slurp request - the behavior that got the feature disabled back in 0.25. The REPL now renders the URL plus a[show content]button and nothing is transferred (or connected to) until it's pressed. Inline image results are unaffected: they involve no IO and still render automatically.With the danger gone,
cider-repl-use-content-typesdefaults tot, so images finally render in the REPL out of the box. Docs updated accordingly, including the troubleshooting entry that used to recommend disabling the feature.